Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on-error annotation for Velero hooks #2319

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

qpdpQ
Copy link
Contributor

@qpdpQ qpdpQ commented Dec 3, 2024

What this PR does / why we need it:
Add on-error annotations for Velero hooks
If script specified in velero hooks failed, the status of restore CR should be fail as well.

Which issue(s) this PR fixes:
Enhancement for # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/62663

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qpdpQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bluzarraga
Copy link
Member

/lgtm

@ibm-ci-bot ibm-ci-bot merged commit c038c3e into IBM:scripts-dev Dec 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants