Add output_file parameter for type -onboarding #232
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadmorales
force-pushed
the
add_output_file
branch
from
01e964b to
f08de5c
Compare
Signed-off-by: Chad Morales <[email protected]>
chadmorales
force-pushed
the
add_output_file
branch
from
f08de5c to
7f5c7fc
Compare
|
|
Failure was due to the fact OnboardingData is now expected to have outputFile and was not present in the test useCase's. It is guaranteed to be set when onboarding payload is created outside OnboardingData in NotificationObject:init() onboarding tests updated and passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an accepted parameter for type -onboarding to define the output file. By defining a unique output file we may find more use cases where a generic wizard/walkthrough would be helpful. This was brought up in #230