fix(ibm-use-date-based-format): tighten heuristic for flagging date-time values #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
requested changes
Jan 23, 2025
dpopp07
force-pushed
the
dp/tighten-date-time-regex
branch
from
fefa97b to
b53d97c
Compare
…ime values The regular expressions used to determine if a value should be considered a date-time value are too loose and allow false positives to sneak in. It's a tricky problem, but this commit makes an attempt to tighten them by dismissing the possibility of a date-time value if any letters are found that are not relevant to a date-time value. Signed-off-by: Dustin Popp <[email protected]>
dpopp07
force-pushed
the
dp/tighten-date-time-regex
branch
from
b53d97c to
4f99241
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jan 24, 2025
## @ibm-cloud/openapi-ruleset [1.28.3](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/[email protected]...@ibm-cloud/[email protected]) (2025-01-24) ### Bug Fixes * **ibm-use-date-based-format:** tighten heuristic for flagging date-time values ([#717](#717)) ([542d6b0](542d6b0))
|
🎉 This PR is included in version 1.28.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.32.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The regular expressions used to determine if a value should be considered a date-time value are too loose and allow false positives to sneak in. It's a tricky problem, but this commit makes an attempt to tighten them by dismissing the possibility of a date-time value if any letters are found that are not relevant to a date-time value.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
.secrets.baselinehas been updated as needednpm run generate-utilities-docshas been run if any files inpackages/utilities/srchave been updated