Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unit tests #131

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix/unit tests #131

merged 3 commits into from
Sep 4, 2024

Conversation

n1ckl0sk0rtge
Copy link
Member

@n1ckl0sk0rtge n1ckl0sk0rtge commented Sep 4, 2024 •
edited
Loading

  • remove unnecessary tests
  • fix JCA unit tests
  • add TestBase class to output module

@n1ckl0sk0rtge n1ckl0sk0rtge added the enhancement New feature or request label Sep 4, 2024
@n1ckl0sk0rtge n1ckl0sk0rtge self-assigned this Sep 4, 2024
hugoqnc
hugoqnc approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@hugoqnc hugoqnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1ckl0sk0rtge n1ckl0sk0rtge merged commit 8581e98 into main Sep 4, 2024
0 of 2 checks passed
@n1ckl0sk0rtge n1ckl0sk0rtge deleted the fix/unit-tests branch September 4, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoqnc hugoqnc hugoqnc approved these changes

Assignees

@n1ckl0sk0rtge n1ckl0sk0rtge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n1ckl0sk0rtge @hugoqnc