Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #16 #141

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix issue #16 #141

merged 2 commits into from
Sep 16, 2024

Conversation

n1ckl0sk0rtge
Copy link
Member

@hugoqnc I've checked that this doesn't break any other tests in Java, but I haven't checked it for BC. Please do so before we merge this PR.

Should fix #16

Signed-off-by: Nicklas Körtge <[email protected]>
@n1ckl0sk0rtge n1ckl0sk0rtge added the bug Something isn't working label Sep 11, 2024
@n1ckl0sk0rtge n1ckl0sk0rtge self-assigned this Sep 11, 2024
Signed-off-by: Hugo Queinnec <[email protected]>
Copy link
Contributor

@hugoqnc hugoqnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: it does not break any BC test, and it succeeds on the test NextParameterDependingRulesTest which I wrote some time ago specifically to test this issue

@hugoqnc hugoqnc merged commit 726889b into main Sep 16, 2024
1 of 2 checks passed
@hugoqnc hugoqnc deleted the fix/issue-16 branch September 16, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next parameter depending rules may not be handled
2 participants