Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completeness judge #1410

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add completeness judge #1410

wants to merge 5 commits into from

Conversation

pvn25
Copy link
Collaborator

@pvn25 pvn25 commented Dec 4, 2024

Add LLM-based judge to check for completeness: if the response is complete with respect to the information in the document.

@pvn25 pvn25 requested review from eladven and yoavkatz December 4, 2024 02:42
},
"generic_inference_engine": {
"model_name": "generic",
"inference_model": (GenericInferenceEngine()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a simpler way to support multiple inference engines in the judge using one consistent API, and that's with CrossProviderInferenceEngine.

https://www.unitxt.ai/en/latest/docs/inference.html#creating-a-cross-api-engine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the standard OpenAI params names.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I updated the engine to CrossProvider. Pls check now.

@yoavkatz
Copy link
Member

yoavkatz commented Dec 4, 2024

Please see these formatting errors:

prepare/templates/response_assessment/judges/completeness/v5.py:6:6056: RUF001 String contains ambiguous (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)? prepare/templates/response_assessment/judges/completeness/v5.py:6:6169: RUF001 String contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)?
prepare/templates/response_assessment/judges/completeness/v5.py:6:7288: RUF001 String contains ambiguous (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)? prepare/templates/response_assessment/judges/completeness/v5.py:6:7401: RUF001 String contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)?
prepare/templates/response_assessment/judges/completeness/v5.py:6:8672: RUF001 String contains ambiguous (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)? prepare/templates/response_assessment/judges/completeness/v5.py:6:8785: RUF001 String contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)?
prepare/templates/response_assessment/judges/completeness/v5.py:6:10086: RUF001 String contains ambiguous (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)? prepare/templates/response_assessment/judges/completeness/v5.py:6:10199: RUF001 String contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)?
prepare/templates/response_assessment/judges/completeness/v5.py:6:11441: RUF001 String contains ambiguous (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)? prepare/templates/response_assessment/judges/completeness/v5.py:6:11554: RUF001 String contains ambiguous `’` (RIGHT SINGLE QUOTATION MARK). Did you mean (GRAVE ACCENT)?
Found 11 errors (1 fixed, 10 remaining).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants