Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Intersect operator #1531

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

pklpriv
Copy link
Member

@pklpriv pklpriv commented Jan 20, 2025

In this PR Intersect() operator is updated. It allows us to filter out some values from data when running benchmarks. Additionally, test were updated and rewritten for more readability.

Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues:
(1) This is not backward compatible, what if anyone using it now?
(2) The same behavior can be achieved with current implementation:
Intersect(field_to_field={"label": "label", "name": "name"}, allowed_values=["b", "f"])

Am I missing something?

@yoavkatz
Copy link
Member

Two issues: (1) This is not backward compatible, what if anyone using it now? (2) The same behavior can be achieved with current implementation: Intersect(field_to_field={"label": "label", "name": "name"}, allowed_values=["b", "f"])

Am I missing something?

This relates to a need (e.g in ner datasets) to filter multiple fields together ( e.g keep only two entity types and remove the start ,end, and label fields).

The current code changes are not backwards compatible (e.g hard code the field to " labels").

I'll write more details later on how to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants