Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add granite documents format #1566

Merged
merged 4 commits into from
Feb 2, 2025
Merged

Add granite documents format #1566

merged 4 commits into from
Feb 2, 2025

Conversation

elronbandel
Copy link
Member

No description provided.

Signed-off-by: elronbandel <[email protected]>
dataset = load_dataset(
card=card,
template_card_index="simple",
format=GraniteDocumentsFormat(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set the model name in explicit way, just in case things change in the future and there are multiple granite ones

@yoavkatz
Copy link
Member

Need to change | to Union to support old python versions.

File "/home/runner/work/unitxt/unitxt/src/unitxt/formats.py", line 43, in GraniteDocumentsFormat
self, instance: Dict[str, Any], stream_name: str | None = None
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

@elronbandel elronbandel merged commit 912dc2a into main Feb 2, 2025
17 of 18 checks passed
@elronbandel elronbandel deleted the add-granite-docs-format branch February 2, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants