Add tokenization and truncation funcionality to Tokenize() function. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdebayser
reviewed
Jun 13, 2024
| pytest.fail(f"gRPC call failed with error: {e}") | ||
|
|
||
| # Verify the response | ||
| expected_response = test_case['response'] |
There was a problem hiding this comment.
Better replace with test_case['response'][0] and eliminate the for loop below.
maxdebayser
reviewed
Jun 13, 2024
| def test_tokenization(server, grpc_stub, test_case): | ||
| """Test tokenization with the given test case.""" | ||
| text = test_case['request']['text'] | ||
| truncate_input_tokens = test_case['request'].get('truncate_input_tokens', |
There was a problem hiding this comment.
Perhaps you can add a new variable request = test_case['request'] to eliminate some repetition.
maxdebayser
reviewed
Jun 13, 2024
| return_offsets_mapping=request.return_offsets | ||
| ) # Tokenize the input text and get offset_mapping | ||
|
|
||
| # Tokenize the input text async |
There was a problem hiding this comment.
Comment doesn't match what the code does.
maxdebayser
reviewed
Jun 13, 2024
| token_count = len(token_ids) | ||
|
|
||
| # Truncate the token count if truncate_input_tokens | ||
| if 1 <= request.truncate_input_tokens < token_count: |
There was a problem hiding this comment.
I think it would be easier to read 0 < request...tokens < token_count.
maxdebayser
reviewed
Jun 13, 2024
|
|
||
| # Return the batched tokenization response |
There was a problem hiding this comment.
I think you can remove most of these comments because it's fairly obvious what the code does.
|
Closing this PR as I have created a more organized one: #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we use of
tokenizer.encode_plus()directly because we don't want to modifytokenizer_group.encode_asyncand this function is part of upstream code/project. This implementation won't affect performance becausetokenizer_group.encode_asyncdoesn't runTokenizer.encodein a background thread.Should we add a unittest for this implementation?