📝 Describe repo organization and processes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
joerunde
force-pushed
the
repo-organization
branch
from
a049d99 to
c7d49cf
Compare
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
|
snuck in some formatting fixes so we can have some ✅ s on Thanks for the review @njhill! |
joerunde
force-pushed
the
repo-organization
branch
from
e01ad79 to
0d8460a
Compare
|
(jk, running the |
njhill
approved these changes
Mar 26, 2024
| ResponseOptions, | ||
| SingleGenerationRequest, | ||
| StopReason, TokenInfo, | ||
| TokenizeResponse) |
There was a problem hiding this comment.
yeah this makes me a bit sad
There was a problem hiding this comment.
yeah I'm not really sure what was going on- format.sh did this but then the yapf check failed on it :/
|
just gonna go ahead and merge so we have it, we can always update formatting more later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new TGIS specific readme with some docs about what this repo is, the diffs it contains from vLLM, and instructions on how to manage our contributions.