Close renderer headless browser in finally block. #8980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fniessink
force-pushed
the
8979-renderer-has-zombie-processes-when-pdf-creation-fails
branch
3 times, most recently
from
fa423ed
to
3ffae07
Compare
wkoot
reviewed
Jun 15, 2024
Closing the Chromium browser in the renderer component after creating a PDF would not stop all browser child processes. Fixed by starting Chromium only once and reusing, instead of starting a new browser for each render. Fixes #8979.
fniessink
force-pushed
the
8979-renderer-has-zombie-processes-when-pdf-creation-fails
branch
from
3ffae07
to
1ba0de1
Compare
|
fniessink
deleted the
8979-renderer-has-zombie-processes-when-pdf-creation-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent zombie browser processes when creating the PDF fails by moving browser.close() to a finally block of the try/catch.
Closes #8979.