Skip to content

Commit

Permalink
Increase the maximum number of lines of code for functions of javascr…
Browse files Browse the repository at this point in the history
…ipt and typescript (#78)

Functions should not have too many lines of code. Change from 20 to 40 for JavaScript and TypeScript
  • Loading branch information
denniebouman authored May 1, 2024
1 parent 9c2f094 commit 35dd168
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"+javascript:S109 # Magic numbers; NOT used by Quality-time",
"+javascript:S125 # Used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#commented-out-code)",
"+javascript:S134 # NOT used by Quality-time",
"+javascript:S138|max=20 # Methods with too many lines; used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#long-units)",
"+javascript:S138|max=40 # Methods with too many lines; used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#long-units)",
"+javascript:S1541|maximumFunctionComplexityThreshold=10 # Used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#complex-units)",
"# Missing: NoSonar, NCSS, Parameters"
],
Expand Down Expand Up @@ -134,7 +134,7 @@
"+typescript:S1067 # Expression too complex; NOT used by Quality-time",
"+typescript:S107|maximumFunctionParameters=5 # Too many parameters; used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#many-parameters)",
"+typescript:S109 # Magic number; NOT used by Quality-time",
"+typescript:S138|max=20 # Methods with too many lines; used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#long-units)",
"+typescript:S138|max=40 # Methods with too many lines; used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#long-units)",
"+typescript:S1541|Threshold=10 # Used by Quality-time (https://quality-time.readthedocs.io/en/latest/reference.html#complex-units)",
"+typescript:S4204 # The 'any' type should not be used; NOT used by Quality-time",
"-typescript:S4328 # reason: the rule does not recognize 'local' imports"
Expand Down

0 comments on commit 35dd168

Please sign in to comment.