Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SVG's and Index.html #24

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adarshsingh1706
Copy link

"Added SVG for Eng, Ned and Nz and also changed index.html to include the svg's so that points table could have correct flags in the name of country".

Included the 3 new SVG's for Nz,Eng and Ned for points table
Copy link
Collaborator

@varun10sudhir varun10sudhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flags are not of equal size and are not aligned properly.
Kindly fix that

@adarshsingh1706
Copy link
Author

Kindly check now about the same , changes have been made.

Copy link
Collaborator

@varun10sudhir varun10sudhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New Zealand flag is incorrect
  • Flags are still not fully aligned
    Also , can u try increasing the size of all the flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants