Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add my subscription page #156

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add my subscription page #156

merged 1 commit into from
Nov 12, 2024

Conversation

barshathakuri
Copy link
Collaborator

@barshathakuri barshathakuri commented Oct 23, 2024 •
edited
Loading

Addresses:

Depends on:

  • XXX

Changes

  • Add subscription page
  • Add subscribe tab
  • Add archive tab

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@barshathakuri barshathakuri marked this pull request as draft October 23, 2024 10:50
AdityaKhatri
AdityaKhatri requested changes Oct 24, 2024
View reviewed changes
src/App/routes/index.tsx Outdated
props: {},
},
context: {
title: 'My Subscription',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'My Subscription',
title: 'My Subscriptions',

src/App/routes/index.tsx Outdated
@@ -57,6 +57,20 @@ const homeLayout = customWrapRoute({
},
});

const mySubscription = customWrapRoute({
parent: rootLayout,
path: 'subscription',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path: 'subscription',
path: 'subscriptions',

src/components/Navbar/i18n.json Outdated
@@ -6,6 +6,8 @@
"appAbout": "About",
"appResources": "Resources",
"headerMenuHome": "Home",
"headerMenuMySubscription": "My Subscription"
"headerMenuMySubscription": "My Subscription",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"headerMenuMySubscription": "My Subscription",
"headerMenuMySubscription": "My Subscriptions",

src/views/Home/AlertsMap/index.tsx Outdated
Comment on lines 86 to 89
const [isModalOpen, setModalOpen] = useState(false);

const openModal = () => setModalOpen(true);
const closeModal = () => setModalOpen(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use useModalState or useBooleanState

src/views/Home/AlertsTable/index.tsx Outdated
Comment on lines 113 to 116
const [isModalOpen, setModalOpen] = useState(false);

const openModal = () => setModalOpen(true);
const closeModal = () => setModalOpen(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before

src/views/MySubscription/ArchiveSubscription/SubscriptionDetail/SubscriptionActions/index.tsx Outdated
@@ -0,0 +1,43 @@
import { MoreOptionsIcon } from '@ifrc-go/icons';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary components

src/views/MySubscription/ArchiveSubscription/SubscriptionDetail/index.tsx Outdated
@@ -0,0 +1,38 @@
import { Container } from '@ifrc-go/ui';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a single one and reuse in both

src/views/MySubscription/ArchiveSubscription/SubscriptionDetail/index.tsx Outdated
import styles from './styles.module.css';

interface Props {
data: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send necessary data individually

src/views/MySubscription/index.tsx Outdated
Comment on lines 28 to 32
const [isModalOpen, setModalOpen] = useState(false);

const openModal = () => setModalOpen(true);

const closeModal = () => setModalOpen(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not do this

src/views/NewSubscriptionModal/index.tsx Outdated
Comment on lines 23 to 201
const [isCheckboxChecked, setCheckboxChecked] = useState(false);
const [selectedValue, setSelectedValue] = useState('daily');
const [alertTitle, setAlertTitle] = useState('');

const handleCheckboxChange = (checked: any) => {
setCheckboxChecked(checked);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a proper form based on the created subscription data structure

@AdityaKhatri AdityaKhatri changed the base branch from develop to project/phase-2-dummy-pages October 29, 2024 10:40
@barshathakuri barshathakuri force-pushed the feature/subscription-table branch 2 times, most recently from 66a57d4 to 2cbc2b4 Compare November 12, 2024 05:40
@AdityaKhatri AdityaKhatri merged commit 3d1ebe0 into project/phase-2-dummy-pages Nov 12, 2024
4 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/subscription-table branch November 12, 2024 06:04
roshni73 pushed a commit that referenced this pull request Nov 12, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
598800c 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 12, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
2a0ff1c 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 12, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
d830cce 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 14, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
398bb5d 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 14, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
edb4d6e 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 14, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
7131fc7 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 15, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
66b8aad 
Add my subscription page
roshni73 pushed a commit that referenced this pull request Nov 18, 2024
@AdityaKhatri @roshni73
Merge pull request #156 from IFRCGo/feature/subscription-table
55c258e 
Add my subscription page
@barshathakuri barshathakuri mentioned this pull request Nov 22, 2024
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

@samshara samshara Awaiting requested review from samshara

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@tnagorra tnagorra Awaiting requested review from tnagorra

Assignees

@tnagorra tnagorra

@frozenhelium frozenhelium

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barshathakuri @AdityaKhatri @tnagorra @frozenhelium @samshara