Euler angle pullreq #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implements the specification that the 3 x,y,z properties in the RotateTransform are to be interpreted as euler angle rotations (measure in degrees), to be interpreted in the intrinsic axis order XYZ
which is a low precision test that the resulting camera orientation met the visual requirements. THe plan is to add more exacting tests.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
gjcope
reviewed
Aug 13, 2024
| @@ -18,5 +18,7 @@ export class RotateTransform extends Transform { | |||
| } | |||
| return retVal; | |||
| } | |||
|
|
|||
| get Rotation() : object { return this.getRotation(); } | |||
There was a problem hiding this comment.
Looks good, but curious of the utility - is this to keep with an accessor standard in the rest of the codebase?
There was a problem hiding this comment.
Yes, the existing code for Presentation 3 manifests uses getPropertyName() for accessors, so the 3D extensions provides this as well. As a personal preference I prefer the .PropertyName accessor, so I added this for Rotation. Admittedly this is inconsistent and does puff up the source code a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function eulerFromRotateTransform which returns a Threejs object EulerAngle obtained from a IIIF-3D RotateTransform instance under convention that the angles are in degrees and are to be interpreted as instrinsic rotations in the XYZ order. This order is the default ThreeJS ordering but is explicitly specified in the code for documentation purpose.