5 lisa new independent recovery analysis #6
Conversation
There was a problem hiding this comment.
For test_ independentrecovery.py, please refer to the tutorial section Create test for new analysis.
It should be under tests > pyincore_incubator > analyses. The related files should be in the same folder as well.
Also, the test doesn't pass. Please modify it accordingly.
| # and is available at https://www.mozilla.org/en-US/MPL/2.0/ | ||
|
|
||
|
|
||
| from pyincore.analyses.independentrecovery.independentrecovery import IndependentRecovery |
There was a problem hiding this comment.
This line should be from pyincore_incubator.analyses.independentrecovery.independentrecovery import IndependentRecovery, because independentrecovery belongs to pyincore_incubator
| @@ -0,0 +1,37 @@ | |||
| from pyincore import IncoreClient, RepairService, MappingSet, Dataset, DataService | |||
| from pyincore.analyses.independentrecovery.independentrecovery import IndependentRecovery | |||
There was a problem hiding this comment.
This line should be from pyincore_incubator.analyses.independentrecovery import IndependentRecovery
ylyangtw
requested review from
navarroc,
jonglee1,
ywkim312,
longshuicy and
Rashmil-1999
|
@IN-CORE/core-dev For testing, please install this pyincore PR IN-CORE/pyincore#606 |
No description provided.