Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tuning for building damage #516

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Performance tuning for building damage #516

merged 9 commits into from
Mar 8, 2024

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Mar 7, 2024 •
edited
Loading

Run test_slc_buildingdamage.py for testing.

For me, the results are:
(before) 170s
(after) 99s

@ylyangtw ylyangtw marked this pull request as draft March 7, 2024 14:36
@longshuicy longshuicy linked an issue Mar 7, 2024 that may be closed by this pull request
Optimize building damage performance #513
Closed
@ylyangtw ylyangtw marked this pull request as ready for review March 7, 2024 18:26
ylyangtw and others added 3 commits March 7, 2024 13:54
@ylyangtw
speed up using pre-filter on mapped/unmapped buildings
1ff479d
@ylyangtw
improve lens
5410e1c
@navarroc
Added cache to store fragility matches and the inventory attributes s… (
7aadf6a 
#517)

* Added cache to store fragility matches and the inventory attributes so like structures can pull from the cache

* Add caching for both new and old rule sets

* Updated to handle both old and new rule parsing when building the cache
@ylyangtw ylyangtw requested review from longshuicy and navarroc March 7, 2024 20:22
navarroc
navarroc approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and compare the building damage output of test_buildingdamage.py using the develop branch and this branch and the outputs match.

longshuicy
longshuicy approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all the test_xxx under building damage. Besides tornado (which has randomness), everything else looks good. Approve.

@longshuicy longshuicy merged commit ae2c9cd into develop Mar 8, 2024
7 checks passed
@longshuicy longshuicy deleted the Performance-Tuning-for-Building-Damage branch March 8, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroc navarroc navarroc approved these changes

@longshuicy longshuicy longshuicy approved these changes

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

@Vismayak Vismayak Awaiting requested review from Vismayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize building damage performance
3 participants
@ylyangtw @navarroc @longshuicy