Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default internal networks for each service #639

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

longshuicy
Copy link
Member

Set up different internal networks for each services when "internal" flag is set to true.

@longshuicy longshuicy linked an issue Nov 27, 2024 that may be closed by this pull request
@longshuicy longshuicy changed the title add default internal networks for each service Add default internal networks for each service Nov 27, 2024
@navarroc
Copy link
Member

navarroc commented Dec 2, 2024

I don't know if this is overkill, but we may at some point want to add a "local" option for the client for users that wants to test the service running on their local machine (e.g. localhost:8080) . Right now, if we set the client as internal and the url to localhost:8080, the URL set by the user will never used because by internal we mean internal to the cluster and we grab the internal URLs (incore-data-svc:8888, etc). I don't see a way to ever set localhost:8080 and have it use it anymore, unless I missed something.

That being said, this looks good. Do we want to create an RC and test it on the test cluster to verify all the URLs are working?

@longshuicy
Copy link
Member Author

I don't know if this is overkill, but we may at some point want to add a "local" option for the client for users that wants to test the service running on their local machine (e.g. localhost:8080) . Right now, if we set the client as internal and the url to localhost:8080, the URL set by the user will never used because by internal we mean internal to the cluster and we grab the internal URLs (incore-data-svc:8888, etc). I don't see a way to ever set localhost:8080 and have it use it anymore, unless I missed something.

That being said, this looks good. Do we want to create an RC and test it on the test cluster to verify all the URLs are working?

Good idea. I was slightly worried that how to use the localhost:8080. It's not an overkill, I can add that quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable different internal network names
3 participants