Make SQL more generic #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialarmedalien
commented
Feb 13, 2025
| PRIMARY KEY (id) | ||
| ); | ||
|
|
||
| DROP TABLE statements; | ||
| CREATE TABLE statements (stanza TEXT,subject TEXT,predicate TEXT,object TEXT,value TEXT,datatype TEXT,language TEXT); | ||
| CREATE TABLE statements ( |
There was a problem hiding this comment.
formatting this like the other declarations
ialarmedalien
commented
Feb 13, 2025
| @@ -1493,15 +1501,17 @@ CREATE VIEW property_used_with_datatype_values_and_objects AS SELECT | |||
| s1.predicate AS subject, | |||
| s1.predicate, | |||
| s1.datatype AS value | |||
| FROM statements AS s1, statements AS s2 ON (s1.predicate=s2.predicate) | |||
| FROM statements AS s1 | |||
| JOIN statements AS s2 ON (s1.predicate=s2.predicate) | |||
There was a problem hiding this comment.
MySQL doesn't understand , for JOINs so making it explicit
ialarmedalien
commented
Feb 13, 2025
Comment on lines
+1603
to
+1604
| -- patch statements table | ||
| ALTER TABLE statements ADD COLUMN graph TEXT; |
There was a problem hiding this comment.
This currently gets added in the build.Makefile. Is there a reason for not adding it to the schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KBase is currently using the semsql schema with a MySQL database and is likely to use it with other SQL db types in the future. This PR alters a couple of lines to use more generic syntax.
Not sure whether I need to propagate these changes to the various other SQL files and the linkml schema.
Turn off whitespace changes - I didn't realise there were so many trailing spaces in the original file!