Add input type to allow function selector decoding #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydenyer
requested review from
ryanschneider,
basgys and
akuanti
as code owners
|
Could you give a description about the purpose of this PR? |
nthpool
reviewed
Jan 9, 2024
Could be any size Co-authored-by: Nicolas Hewitt <[email protected]>
When someone updates the package the changes should be minimal ™️ - either change the type or cast to Data. |
ryanschneider
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
While my initial thoughts align w/ @nthpool that we could make this a method on say Data instead of introducing a new type, I'm not fully opposed to introducing the new type if necessary.
|
In TLM, we were extending the type anyway. It felt odd having some in there and some in here. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new type
inputto allow new methods to be added forinputtype data.Added
FunctionSelectorfunction to return the first 4 bytes of theinputif present.Future work could include things like
FunctionArgsetc.