Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Error when tracking static method #23

Merged
merged 3 commits into from
Sep 26, 2023
Merged

[Fix] Error when tracking static method #23

merged 3 commits into from
Sep 26, 2023

Conversation

kohlerca
Copy link
Collaborator

This PR fixes a bug that resulted in an exception when the method tracked was decorated with staticmethod. After applying the Provenance decorator, the static method decorator was removed, and therefore the function call included the extra self argument.

Now, when the function is being decorated with Provenance, the method is analyzed to check if it is static, and then the decorator is restored after applying Provenance.

@kohlerca kohlerca added the bugfix Fix for an identified bug label Sep 26, 2023
@kohlerca kohlerca merged commit ca6ab1c into main Sep 26, 2023
5 checks passed
@kohlerca kohlerca deleted the fix/static_method branch September 26, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for an identified bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant