Add threaded-timer support to hpc-benchmark #14
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlober
requested changes
Dec 18, 2024
| timer_array = tuple(d[timer][tid] - intermediate_kernel_status[timer][tid] for tid in range(len(d[timer]))) | ||
| d[timer] = timer_array[0] | ||
| d[timer + "_max"] = max(timer_array) | ||
| d[timer + "_max"] = min(timer_array) |
There was a problem hiding this comment.
Bug: d[timer + "_max"] = min(timer_array) must be d[timer + "_min"] = min(timer_array)
| timers = ['time_collocate_spike_data', 'time_communicate_prepare', | ||
| 'time_communicate_spike_data', 'time_deliver_spike_data', | ||
| 'time_gather_spike_data', 'time_update', 'time_simulate'] | ||
| timers = ['time_collocate_spike_data', 'time_communicate_prepare', 'time_communicate_spike_data', 'time_communicate_target_data', 'time_construction_connect', 'time_construction_create', 'time_deliver_secondary_data', 'time_deliver_spike_data', 'time_gather_secondary_data', 'time_gather_spike_data', 'time_gather_target_data', 'time_omp_synchronization_construction', 'time_omp_synchronization_simulation', 'time_mpi_synchronization', 'time_simulate', 'time_update'] |
There was a problem hiding this comment.
Construction related timers like time_construction_connect and time_gather_target_data should not be used later for subtraction of the presim timers, since they are not part of the presim time. The logfiles should only contain these timers once without distinction into presim and sim.
| d[timer] -= intermediate_kernel_status[timer] | ||
| if type(d[timer]) == tuple or type(d[timer]) == list: | ||
| timer_array = tuple(d[timer][tid] - intermediate_kernel_status[timer][tid] for tid in range(len(d[timer]))) | ||
| d[timer] = timer_array[0] |
There was a problem hiding this comment.
What is the reason for adding only the first value of the tuple to the logfile? And why is this handled differently for the presim timers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this as soon as nest/nest-simulator#3378 is merged into NEST