[ENH] add trial handling to Unitary Events analysis plot_ue
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viziphant/unitary_event_analysis.py
Outdated
| @@ -190,6 +191,8 @@ def plot_ue(spiketrains, Js_dict, significance_level=0.05, | |||
| Refer to `UEA Tutorial <https://elephant.readthedocs.io/en/latest/ | |||
| tutorials/unitary_event_analysis.html>`_ for real-case scenario. | |||
| """ | |||
| if isinstance(spiketrains, Trials): | |||
There was a problem hiding this comment.
use elephant decorator instead
There was a problem hiding this comment.
done: 4330125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces enhancements to the
plot_uefunction inviziphant.unitary_event_analysismodule.Changes:
plot_uefunction has been modified to accept Trials objects directly.elephant => 0.14.0. This version is necessary to ensure that the Trials object is available.