Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and update vignettes #90

Merged
merged 18 commits into from
Mar 3, 2021
Merged

Simplify and update vignettes #90

merged 18 commits into from
Mar 3, 2021

Conversation

kuriwaki
Copy link
Member

This PR makes updates to vignettes for v0.3.x+. They had not been updated since v0.2.0.

Merge remote-tracking branch 'origin/master' into vignettes
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Focus on the dataframe side and cut tangential material
We can later add it back with more text on pyDataverse
As it is no longer used in vignette C, and keeping it causes a NOTE in check().
Can't find sword package anymore, and UNF is not used together and has not been updated recently.
@Danny-dK
Copy link
Contributor

Danny-dK commented Mar 1, 2021

Are you sure you want to remove the sword references? For now that's the only way that I am able to upload datasets. #82

@kuriwaki
Copy link
Member Author

kuriwaki commented Mar 1, 2021

@Danny-dK I missed that sword does work (I was trying to remove parts that have any problems). If you have any updates to that issue, that'll be great when I take a look today.

We included informative error messages in the latest master version (#30)

@Danny-dK
Copy link
Contributor

Danny-dK commented Mar 2, 2021

@kuriwaki No worries. I added a summary in #82 of the code that now works and what doesn't work (as it was indeed getting a bit much in unstructured information).

@kuriwaki
Copy link
Member Author

kuriwaki commented Mar 2, 2021

I updated the part of the README with your example (with eval = FALSE). It is similar to the archiving vignette that was deleted and can be added back.

But given that this is a workaround and there are some questions (e.g. the workaround a mixup of SWORD vs. native API), I'd rather publish a version for which all examples work. The fixes to the the uploading is perhaps a 0.4.0 milestone or pyDataverse task.

@wibeasley what do you think?

@wibeasley
Copy link
Contributor

Looks good, @kuriwaki & @Danny-dK, thanks for keeping all the parts straight.

@wibeasley wibeasley merged commit 8179b92 into master Mar 3, 2021
@wibeasley wibeasley deleted the vignettes branch April 14, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants