[Frontend] Mobile UI Improvements #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JosephZheng1998
commented
Apr 8, 2020
•
JosephZheng1998
commented
- Fixed Count Map bug where popup window does not close when switched to other maps
- Implemented mobile-friendly Hot Topics
- Fixed the PinMap clicking issue due to the Polygon Layer
Update with ISG-ICS/cloudberry
Merge from ISG-ICS
merge commits from master
Merge with ISG master
baiqiushi
reviewed
Apr 8, 2020
| @@ -168,15 +167,18 @@ angular.module("cloudberry.map") | |||
| } | |||
| $scope.previousZoomLevel = event.level; | |||
| sendPinmapTimeQuery(); | |||
|
|
|||
| $scope.deletePolygonLayers(); | |||
There was a problem hiding this comment.
I think these delete calls made us can not find the bug when they will be added again. Since we know where they are added, let's remove these delete calls. Only call the delete when we switch to pinmap from countmap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.