Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOC generator: issues #4659

Closed
Tom-Willemsen opened this issue Aug 19, 2019 · 7 comments
Closed

IOC generator: issues #4659

Tom-Willemsen opened this issue Aug 19, 2019 · 7 comments
Assignees
Labels
0 bug no_release_notes Tickets that do not need release notes, use sparingly! training

Comments

@Tom-Willemsen
Copy link
Contributor

As a developer I would like the IOC generator to work

Ran the generator with @JamesKingWork on a completely clean install:

  • It failed to add the support module (because it didn't init the submodule?) and we had to manually delete it, recreate the structure and re-add it correctly
  • It repeatedly warned that it was not pushing to git, but in reality was pushing to git.
@DominicOram
Copy link
Contributor

As part of this the IOC generator should be updated to match the new repo structure in #6555

@rerpha
Copy link
Contributor

rerpha commented Aug 2, 2021

As part of this the IOC generator should be updated to match the new repo structure in #6555

done in #6689 to avoid a huge PR that solves several issues.

@rerpha rerpha self-assigned this Aug 6, 2021
@rerpha
Copy link
Contributor

rerpha commented Aug 6, 2021

Right, so it's a bit difficult to create the repository on github locally without messing about with API tokens and so on, so I suggest we prompt the user to go and do so using a link given.

@JamesKingWork
Copy link
Contributor

That would be fine, but if possible it would be nice to have it automated, see https://github.com/ISISComputingGroup/ScriptGeneratorReleases/blob/master/create_release.py for an example of using API tokens

@rerpha
Copy link
Contributor

rerpha commented Aug 6, 2021

Think it;s unlikely I can get this done and ready for review (and someone review it) by the end of the day, so going to unassign myself and leave for the next tech debt week. I am going to propose as it would help with the upcoming migrations but suspect it may not be the highest priority ticket.

@rerpha rerpha removed their assignment Aug 6, 2021
@rerpha rerpha added the proposal label Aug 6, 2021
@rerpha
Copy link
Contributor

rerpha commented Aug 19, 2021

I have made the device generator not use git by default: ISISComputingGroup/IBEX_device_generator_old#14

whoever does this ticket will need to revert this when the git operations are fixed.

@NikolaRoev
Copy link

@rerpha rerpha added the no_release_notes Tickets that do not need release notes, use sparingly! label Aug 8, 2022
@rerpha rerpha closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 bug no_release_notes Tickets that do not need release notes, use sparingly! training
Projects
None yet
Development

No branches or pull requests

6 participants