-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 8067 switch instruments #1669
base: master
Are you sure you want to change the base?
Conversation
If I make a change in the Experiment Setup Panel for Local --> Apply Change button is highlighted as expected. Discussed with Daniel and it is agreed that this isn't an issue as retaining local unapplied changes is only relevant while we are within the context of an instrument and switching instruments takes us to a different context. |
This looks ok. Please feel free to delete the branch once you think it is safe. |
Re-opened this as there are conflicts. Please check the script_definition. It may not be needed |
Description of work
The UI and GUI seems to be out of sync, code was added to bring them back inline after switching instruments.
Ticket
Link to Ticket
Acceptance criteria
See Ticket
Unit tests
Squish test added - tst_make_change_without_applying_and_switch_instrument
Code Review
check_opi_format.py
script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps