Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python ruff linting and pyright #199

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Add python ruff linting and pyright #199

merged 4 commits into from
Aug 5, 2024

Conversation

LowriJenkins
Copy link
Contributor

@LowriJenkins LowriJenkins commented Jul 12, 2024 •
edited
Loading

@LowriJenkins LowriJenkins mentioned this pull request Jul 12, 2024
Closed
4 tasks
@LowriJenkins LowriJenkins force-pushed the Ticket8378_add_linting_action branch from 3c63986 to 4c3c5ab Compare July 19, 2024 07:55
@LowriJenkins LowriJenkins force-pushed the Ticket8378_add_linting_action branch from 31bf291 to 39ca07e Compare August 1, 2024 08:53
jackbdoughty
jackbdoughty approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pyright should be failing on this PR (?) (Fixed)

jackbdoughty
jackbdoughty approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works.

@jackbdoughty jackbdoughty merged commit 25d0d6d into master Aug 5, 2024
2 of 3 checks passed
@jackbdoughty jackbdoughty deleted the Ticket8378_add_linting_action branch August 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackbdoughty jackbdoughty jackbdoughty approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LowriJenkins @jackbdoughty