Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysql to 8.0.39 #202

Closed
wants to merge 2 commits into from
Closed

Update mysql to 8.0.39 #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be07c9d
Update mysql to 8.0.39
FreddieAkeroyd Aug 14, 2024
44c1f22
Fix linting
Tom-Willemsen Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 39 additions & 32 deletions installation_and_upgrade/ibex_install_utils/tasks/mysql_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import subprocess
import zipfile
from time import sleep
from typing import Generator

from ibex_install_utils.admin_runner import AdminCommandBuilder
from ibex_install_utils.exceptions import ErrorInRun
Expand Down Expand Up @@ -35,7 +36,7 @@

MYSQL8_INSTALL_DIR = os.path.join(APPS_BASE_DIR, "MySQL")
MYSQL57_INSTALL_DIR = os.path.join("C:\\", "Program Files", "MySQL", "MySQL Server 5.7")
MYSQL_LATEST_VERSION = "8.0.32"
MYSQL_LATEST_VERSION = "8.0.39"
MYSQL_ZIP = os.path.join(
INST_SHARE_AREA,
"kits$",
Expand Down Expand Up @@ -64,7 +65,7 @@ class MysqlTasks(BaseTasks):
Tasks relating to installing or maintaining an installation of MySQL on a machine.
"""

def _get_mysql_dir(self):
def _get_mysql_dir(self) -> str:
"""
Returns the mysql 8 default install directory if it exists, else 5.7.

Expand All @@ -76,7 +77,7 @@ def _get_mysql_dir(self):

return mysql_bin_dir

def _get_mysql_backup_dir(self):
def _get_mysql_backup_dir(self) -> str:
mysql_backup_dir = os.path.join(
STAGE_DELETED,
self._get_machine_name(),
Expand All @@ -87,14 +88,18 @@ def _get_mysql_backup_dir(self):
return mysql_backup_dir

@task("Truncate database")
def truncate_database(self):
def truncate_database(self) -> None:
"""
Truncate the message log, sample and alarms tables
"""
try:
mysql_bin_dir = self._get_mysql_dir()

sql_command = "truncate table msg_log.message;truncate table archive.sample;truncate table alarm.pv"
sql_command = (
"truncate table msg_log.message;"
"truncate table archive.sample;"
"truncate table alarm.pv"
)

RunProcess(
MYSQL_FILES_DIR,
Expand All @@ -110,7 +115,7 @@ def truncate_database(self):
f"Error is {ex}"
)

def _configure_mysql(self):
def _configure_mysql(self) -> None:
"""
Copy mysql settings and run the MySQL configuration script
"""
Expand All @@ -131,7 +136,7 @@ def _configure_mysql(self):
admin_commands.add_command("sc", "start MYSQL80", expected_return_val=None)
admin_commands.run_all()

def _remove_old_versions_of_mysql8(self, clean_install):
def _remove_old_versions_of_mysql8(self, clean_install: bool) -> None:
if clean_install:
self.prompt.prompt_and_raise_if_not_yes(
"Warning: this will erase all data held in the MySQL database. "
Expand All @@ -151,11 +156,11 @@ def _remove_old_versions_of_mysql8(self, clean_install):
if clean_install:
self._remove_old_mysql_data_dir()

def _remove_old_mysql_data_dir(self):
def _remove_old_mysql_data_dir(self) -> None:
if os.path.exists(MYSQL_FILES_DIR):
shutil.rmtree(MYSQL_FILES_DIR)

def _create_mysql_binaries(self):
def _create_mysql_binaries(self) -> None:
os.makedirs(MYSQL8_INSTALL_DIR)

mysql_unzip_temp = os.path.join(APPS_BASE_DIR, "temp-mysql-unzip")
Expand All @@ -171,7 +176,7 @@ def _create_mysql_binaries(self):

shutil.rmtree(mysql_unzip_temp)

def _initialize_mysql_data_area_for_vhd(self):
def _initialize_mysql_data_area_for_vhd(self) -> None:
os.makedirs(os.path.join(MYSQL_FILES_DIR, "data"))

RunProcess(
Expand All @@ -187,7 +192,7 @@ def _initialize_mysql_data_area_for_vhd(self):
).run()

@contextlib.contextmanager
def temporarily_run_mysql(self, sql_password: str):
def temporarily_run_mysql(self, sql_password: str) -> Generator[None, None, None]:
mysqld = os.path.join(MYSQL8_INSTALL_DIR, "bin", "mysqld.exe")

# spawn service in background
Expand All @@ -211,7 +216,7 @@ def temporarily_run_mysql(self, sql_password: str):
log_command_args=False, # To make sure password doesn't appear in jenkins log.
).run()

def _setup_database_users_and_tables(self, vhd_install=True):
def _setup_database_users_and_tables(self, vhd_install: bool = True) -> None:
sql_password = self.prompt.prompt(
"Enter the MySQL root password:",
UserPrompt.ANY,
Expand All @@ -235,8 +240,8 @@ def _setup_database_users_and_tables(self, vhd_install=True):
"-u",
"root",
"-e",
f"ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY '{sql_password}';FLUSH "
f"privileges; ",
f"ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY "
f"'{sql_password}';FLUSH privileges; ",
],
log_command_args=False, # To make sure password doesn't appear in jenkins log.
).run()
Expand All @@ -249,7 +254,7 @@ def _setup_database_users_and_tables(self, vhd_install=True):
log_command_args=False, # To make sure password doesn't appear in jenkins log.
).run()

def _setup_mysql8_service(self):
def _setup_mysql8_service(self) -> None:
mysqld = os.path.join(MYSQL8_INSTALL_DIR, "bin", "mysqld.exe")
admin_commands = AdminCommandBuilder()

Expand All @@ -260,8 +265,8 @@ def _setup_mysql8_service(self):
)

admin_commands.add_command("sc", "start MYSQL80", expected_return_val=None)
# we use "delayed-auto" for start= as we have some ibex installations where a required disk volume
# doesn't get mounted in time if just "auto" is used
# we use "delayed-auto" for start= as we have some ibex installations where a required disk
# volume doesn't get mounted in time if just "auto" is used
admin_commands.add_command("sc", "config MYSQL80 start= delayed-auto")
admin_commands.add_command(
"sc", "failure MYSQL80 reset= 900 actions= restart/10000/restart/30000/restart/60000"
Expand All @@ -281,10 +286,10 @@ def _setup_mysql8_service(self):

admin_commands.run_all()

def _install_latest_mysql8(self, clean_install):
def _install_latest_mysql8(self, clean_install: bool) -> None:
"""
Install the latest mysql. If this is a clean install remove old data directories first and create a new
database
Install the latest mysql. If this is a clean install remove old data directories first and
create a new database
Args:
clean_install: True to destroy and recreate data directories
"""
Expand All @@ -311,13 +316,14 @@ def _install_latest_mysql8(self, clean_install):
self._setup_database_users_and_tables(vhd_install=False)

@task("Install latest MySQL for VHD deployment")
def install_mysql_for_vhd(self):
def install_mysql_for_vhd(self) -> None:
"""
Installs MySQL for the VHD creation build.

Ensure we start from a clean slate. We are creating VHDs so we can assume that no files should exist in
C:\instrument\apps\mysql or c:\instrument\var\mysql and delete them if they do exist. This facilitates
developer testing/resuming the script if it failed halfway through
Ensure we start from a clean slate. We are creating VHDs so we can assume that no files
should exist in C:\instrument\apps\mysql or c:\instrument\var\mysql and delete them if they
do exist. This facilitates developer testing/resuming the script if it failed halfway
through
"""
for path in [MYSQL_FILES_DIR, MYSQL8_INSTALL_DIR]:
if os.path.exists(path):
Expand All @@ -338,7 +344,7 @@ def install_mysql_for_vhd(self):

self._setup_database_users_and_tables(vhd_install=True)

def _install_vcruntime140(self):
def _install_vcruntime140(self) -> None:
if not os.path.exists(VCRUNTIME140):
self.prompt.prompt_and_raise_if_not_yes(
f"MySQL server 8 requires microsoft visual C++ runtime to be installed.\r\n"
Expand All @@ -347,7 +353,7 @@ def _install_vcruntime140(self):

@version_check(MySQL())
@task("Install latest MySQL")
def install_mysql(self, force=False):
def install_mysql(self, force: bool = False) -> None:
"""
Install mysql and the ibex database schemas
Args:
Expand Down Expand Up @@ -390,7 +396,7 @@ def install_mysql(self, force=False):
self._reload_backup_data()

@task("Configure MySQL for VHD post install")
def configure_mysql_for_vhd_post_install(self):
def configure_mysql_for_vhd_post_install(self) -> None:
"""
configure mysql after vhd is deployed to an instrukent/mdt build
"""
Expand All @@ -399,7 +405,7 @@ def configure_mysql_for_vhd_post_install(self):
sleep(5) # Time for service to start

@task("Backup database")
def backup_database(self):
def backup_database(self) -> None:
"""
Backup the database
"""
Expand Down Expand Up @@ -447,7 +453,7 @@ def backup_database(self):
f"Dump file '{result_file}' seems to be small is it correct? "
)

def _backup_data(self):
def _backup_data(self) -> None:
"""
Backup the data for transfer. This dumps just the data not the schema.
"""
Expand Down Expand Up @@ -487,7 +493,7 @@ def _backup_data(self):
f"Dump file '{result_file}' seems to be small is it correct? "
)

def _reload_backup_data(self):
def _reload_backup_data(self) -> None:
"""
Reload backup the data
"""
Expand All @@ -507,6 +513,7 @@ def _reload_backup_data(self):
std_in=open(result_file),
).run()
self.prompt.prompt_and_raise_if_not_yes(
"Check that there are only 16 errors from mysql. These are 1062 error fail to insert primary key. "
"These are for constants added by the creation script, e.g. archive severity."
"Check that there are only 16 errors from mysql. These are 1062 error fail to insert "
"primary key. These are for constants added by the creation script, e.g. archive "
"severity."
)