-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBEX wiki Checker Python Library Upgraded #4
Open
RaiBishal
wants to merge
1
commit into
master
Choose a base branch
from
4620_Wiki_Checker_Updated_Library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,959
−22
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
set PYTHONIOENCODING=utf-8 | ||
%~dp0Python\python.exe -m pip install requests | ||
%~dp0Python\python.exe -m pip install mock | ||
%~dp0Python\python.exe -m pip install pyspellchecker | ||
%~dp0Python\python.exe run_tests.py --remote |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,13 @@ | |
import requests | ||
import concurrent.futures | ||
|
||
from spellchecker import SpellChecker as PySpellChecker | ||
from enchant.checker import SpellChecker | ||
from enchant.tokenize import URLFilter, EmailFilter, WikiWordFilter, MentionFilter | ||
|
||
# Creating this object here to avoid creating duplicates which leads to memory corruption | ||
# not sure why its happening, Garbage collector not quick enough? | ||
checker_py = PySpellChecker() | ||
|
||
def strip_between_tags(expression, text): | ||
if text is None: | ||
|
@@ -25,7 +29,6 @@ def strip_between_tags(expression, text): | |
new_text += text[matches[-1].end(): len(text)] | ||
return new_text | ||
|
||
|
||
class PageTests(unittest.TestCase): | ||
def __init__(self, methodName, ignored_items, wiki_info=None): | ||
""" | ||
|
@@ -81,6 +84,7 @@ def strip_inline_code_blocks(text): | |
def remove_bold_and_italics(text): | ||
return text.replace("*", "") | ||
|
||
|
||
with open(self.page, "r", encoding="utf-8") as wiki_file: | ||
text = remove_bold_and_italics( | ||
replace_selected_specials_with_whitespace( | ||
|
@@ -97,17 +101,20 @@ def remove_bold_and_italics(text): | |
) | ||
) | ||
) | ||
## translate string to lsit of words | ||
list_of_words = re.findall(r"\w+", text) | ||
# check if list of words exist in the dictionary | ||
errors = checker_py.unknown(list_of_words) | ||
|
||
filters = [URLFilter, EmailFilter, MentionFilter, WikiWordFilter] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Getting rid of all these filters means we're now gonna have loads more errors for emails and urls, which we needn't check. |
||
checker = SpellChecker("en_UK", filters=filters, text=text) | ||
|
||
failed_words = filter_upper_case( | ||
{err.word for err in checker if err.word.lower() not in self.ignored_words}) | ||
failed_words = filter_upper_case({ | ||
err for err in errors if err.lower() not in self.ignored_words | ||
}) | ||
|
||
if len(failed_words) > 0: | ||
self.fail("The following words were spelled incorrectly in file {}: \n {}".format( | ||
self.page, "\n ".join(failed_words) | ||
)) | ||
|
||
|
||
def test_GIVEN_a_page_IF_it_contains_urls_WHEN_url_loaded_THEN_response_is_http_ok(self): | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove references to enchant and uninstall it from python if we're no longer using it.