-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Chemical System #616
base: protos
Are you sure you want to change the base?
Conversation
…to maciej/atom-database-in-trajectory
…to maciej/atom-database-in-trajectory
…to maciej/atom-database-in-trajectory
…base-in-trajectory
I've been testing the solvent SolventAccessibleSurface job. According to the MDTraj documentation https://mdtraj.org/1.9.4/examples/solvent-accessible-surface-area.html they also use the method by Shrake and Rupley. Here I run the SolventAccessibleSurface with a trajectory from SlimMD https://www.ccpbiosim.ac.uk/slim-md/slimmd-database/proteins/cyclosporin-a-37ms. Here are the results for the first 1000 time steps. Concentrating on the timestep at 550 (top) and 670 (the peak, bottom) we can see the molecule geometry change. At 670 the molecule is in a more open geometry which agrees with the increase in the solvent accessible surface in MDTraj and this branch. Looks like there were some issues with the implementation of the SolventAccessibleSurface on protos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the extension are all gone we can also delete the MDANSE/Src/MDANSE/Extensions directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the pair distribution function and the self and distinct part of the van Hove function. Here are the timing with the dftb water trajectory, I think we should try to speed up those numpy functions some more if possible.
Before
pair distribution function: 0.7s
van Hove function self: 37s
van Hove function distinct: 20s
After
pair distribution function: 4s
van Hove function self: 33s
van Hove function distinct: 1m 55s
The self part of the van Hove function looks good but I see differences for the distinct part. Looks like the intra and intermolecular parts haven't been split up.
Here is the the inter and intra PDF for the dftb water trajectory with this branch.
It looks like the bonding information got lost when the DFTB trajectory was converted.
Description of work
Most of the classes derived from ChemicalEntity were only used for a very specific case of a trajectory created by GROMACS with a PDB file describing the topology. Since MDANSE is moving to MDAnalysis for loading GROMACS trajectories, the selection mechanism based on fixed databases needs to be replaced with a more general solution. This is provided by rdkit and substructure matching. Since rdkit introduces its own indexing of atoms, not guaranteed to be consistent with the internal indexing of the ChemicalSystem class, changes are necessary to improve the consistency of the atom indexing.
closes #545
Fixes
To test
All unit tests must pass.
A detailed comparison of the results between this and main branches is necessary due to the fundamental changes to the way the code operates.
Please run TrajectoryEditor with molecule detection on a trajectory and check if all the expected Atom Selection options are working correctly in the GUI.
Jobs that require the most attention: