Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint MartinKippenberger: Minor Improvements #1768

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

mrnicegyu11
Copy link
Member

  • Changes / Improves README.md
  • Print sorted-by-dates in scripts/3_deadlines_calendar.py
  • Check for github-API error-return-codes in scripts/4_make_release_drafts.py
  • Minors

@mrnicegyu11 mrnicegyu11 self-assigned this Oct 29, 2024
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one big fishy thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file here? Is it not wrong?

Comment on lines +7 to +8
] = """## Deadlines & upcoming schedule
{sorted_events}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this version way less readable. I preferred the declarative template approach.

This is the draft of the release notes: https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/s4l/{vtag}.md
This is the draft of the release notes:
- s4l https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/s4l/{vtag}.md
- tip https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/tip/{vtag}.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh they also have to handle tip now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.