Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleepers version 2.2.0 #155

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Feb 23, 2024

What do these changes do?

  • use latest Dockerfile best practices
  • standard sleeper is again below 150MB
  • sleeper-mpi/-gpu use latest Cuda 12.3.1
  • adds dream input to generate a file of any size in bytes
  • adds dream output as file of the dream input size for testing
  • simplify generation of synchronized sleeper/-mpi/-gpu with 1 single metadata file
  • upgraded Github workflow file
  • version bumped to 2.2.0
  • uses latest uv version in Github CI

details

  • sleeper uses:
    • python 3.11-slim image
  • sleeper-mpi/-gpu uses
    • nvidia/cuda-12.3.1-base-ubuntu-22.04 image

Related issue number

Checklist

  • I think the code is well written
  • I updated the table of contents (make toc)
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@sanderegg sanderegg requested a review from GitHK as a code owner February 23, 2024 10:07
@sanderegg sanderegg added this to the Schoggilebe milestone Feb 23, 2024
@sanderegg sanderegg added the t:enhancement New feature or request label Feb 23, 2024
@sanderegg sanderegg self-assigned this Feb 23, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for this big cleanup!

services/sleeper/docker/custom/Dockerfile Show resolved Hide resolved
services/sleeper/metadata/metadata.yml Show resolved Hide resolved
Copy link

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade! :) please consider putting even higher upper limit (so we can run it let say for 3 hours?) thanks!

Copy link

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot

services/sleeper/service.cli/run Outdated Show resolved Hide resolved
services/sleeper/validation/input/inputs.json Show resolved Hide resolved
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the deep (sleep) refactoring.

@wvangeit might like it a bit more, since it the code does something (i.e. producing a dream) instead of just waiting for time to pass. 🙃

services/sleeper/metadata/metadata.yml Show resolved Hide resolved
@wvangeit
Copy link

Thanks for the deep (sleep) refactoring.

@wvangeit might like it a bit more, since it the code does something (i.e. producing a dream) instead of just waiting for time to pass. 🙃

Can we let chatgpt generate some hallucinations for the dreams?

@sanderegg sanderegg merged commit 4622407 into ITISFoundation:master Feb 27, 2024
1 check passed
@sanderegg sanderegg deleted the sleepers/increase-sleep-time-limit branch February 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants