✨ long running creation of studies #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3235 +/- ##
========================================
+ Coverage 82.3% 84.3% +1.9%
========================================
Files 752 548 -204
Lines 32119 26005 -6114
Branches 4110 3422 -688
========================================
- Hits 26454 21924 -4530
+ Misses 4829 3388 -1441
+ Partials 836 693 -143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
force-pushed
the
enhancement/long_running_creation_of_studies
branch
9 times, most recently
from
f07f028 to
55dc8d3
Compare
GitHK
reviewed
Aug 18, 2022
services/web/server/src/simcore_service_webserver/projects/projects_handlers_crud.py
Show resolved
Hide resolved
Comment on lines
53
to
57
| @pytest.mark.skip( | ||
| reason="since long running tasks are now used for copying, this is no longer an issue." | ||
| "If the timeout is really super short, then the background task should be properly cancelled." | ||
| "this should be tested now" | ||
| ) |
There was a problem hiding this comment.
Question: why keep the test if no longer required, or did I misunderstand the above message?
There was a problem hiding this comment.
yes, I had forgotten that one. I need to adapt the test.
odeimaiz
approved these changes
Aug 18, 2022
pcrespov
approved these changes
Aug 18, 2022
packages/service-library/src/servicelib/aiohttp/long_running_tasks/_routes.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/modules/webserver.py
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR leverages the new framework for long running REST calls when creating new study in oSparc.
Until now the creation of a study (and its copy with or without data) were done by the webclient calling
POST /projectson the webserver. The latter would create a new study, maybe copy data and return a 201 code.This is now changed to
POST /projectswith same query parametersGET /tasks/{task_id}to find out when the creation completedGET /tasks/{task_id}/result, server will return a 201 code.needs #3260
NOTE: this does not handle yet the use case where the webclient is refreshed (via F5) as the new client will not "recover" its current running tasks. In this case if there is copying involved and it is large, then it will still continue in the background without feedback. The new study might appear at some point.
NOTE: this does not handle the use case where the webserver is restarted in the middle of the task. the task is then lost.
Related issue/s
help with ITISFoundation/osparc-issues#558
How to test
Checklist