Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [e2e] Start from template playwright test #6225

Merged
merged 33 commits into from
Aug 27, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 23, 2024

What do these changes do?

To be used as e2e test and also performance improvement benchmark

New printed logs:
image

Related issue/s

related to ITISFoundation/osparc-issues#1327
closes ITISFoundation/osparc-issues#1674

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 23, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 23, 2024
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (191b79f).
Report is 473 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6225      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1471    +1461     
  Lines         214   61003   +60789     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53775   +53594     
- Misses         23    6913    +6890     
- Partials       10     315     +305     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1421 files with indirect coverage changes

@odeimaiz odeimaiz marked this pull request as ready for review August 27, 2024 13:03
@odeimaiz odeimaiz requested a review from sanderegg as a code owner August 27, 2024 13:03
@odeimaiz odeimaiz enabled auto-merge (squash) August 27, 2024 13:13
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional suggestions. thanks!

tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 27, 2024

@odeimaiz odeimaiz requested a review from GitHK August 27, 2024 13:57
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@odeimaiz odeimaiz merged commit f585573 into ITISFoundation:master Aug 27, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing the performance check e2e
4 participants