-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Check all linked nodes exist before loading Study #6762
🎨 [Frontend] Check all linked nodes exist before loading Study #6762
Conversation
…osparc-simcore into enh/check-links-before-loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍 In my opinion, blocking the study from being opened is a rather harsh solution. I would prefer to remove the corrupted links and display a warning message instead. What if the user needs to open the project to download some data? I wouldn’t prohibit that unless opening the project itself would also be corrupted due to the issue.
@matusdrobuliak66 |
@matusdrobuliak66 Fix and continue could still be an option we provide, making clear that some links will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested something less harsh for the fearful user
services/static-webserver/client/source/class/osparc/desktop/MainPageHandler.js
Outdated
Show resolved
Hide resolved
…ainPageHandler.js Co-authored-by: Andrei Neagu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Quality Gate passedIssues Measures |
What do these changes do?
It can happen (@AntoninoMarioC), still not sure how, that some node inputs point to nodes that do not exist, making the deserialization of the Study when opening it buggy. This PR checks the links before opening a Study and if it finds any mismatch it will block the Study from being open.
Related issue/s
How to test
Dev-ops checklist