Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 adding new scheduling mode to dynamic-scheduler ⚠️ #6889

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 3, 2024

devops ⚠️

  • no further actions required
  • added new env var DYNAMIC_SCHEDULER_USE_INTERNAL_SCHEDULER

What do these changes do?

Currently scheduling of new style dynamic-services is done using the director-v2's scheduler.
Since this is planed to change in the near future. Adding the possibility to switch between schedulers.

  • ✨ added "entry point" interface to allow an easier switch between schedulers

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 3, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (e317f6b) to head (af041a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6889      +/-   ##
==========================================
+ Coverage   88.32%   88.34%   +0.01%     
==========================================
  Files        1553     1547       -6     
  Lines       61193    61022     -171     
  Branches     2095     2095              
==========================================
- Hits        54050    53907     -143     
+ Misses       6812     6783      -29     
- Partials      331      332       +1     
Flag Coverage Δ
integrationtests 68.17% <ø> (+3.10%) ⬆️
unittests 86.50% <100.00%> (-0.01%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.21% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.76% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.06% <ø> (-0.07%) ⬇️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.81% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.36% <ø> (+0.01%) ⬆️
dynamic_scheduler 97.07% <100.00%> (+0.05%) ⬆️
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.77% <ø> (ø)
resource_usage_tracker 88.77% <ø> (-0.30%) ⬇️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.24% <ø> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e317f6b...af041a9. Read the comment docs.

@GitHK GitHK changed the title 🎨 adding new scheduling mode to dynamic-scheduler 🎨 adding new scheduling mode to dynamic-scheduler ⚠️ Dec 3, 2024
@GitHK GitHK marked this pull request as ready for review December 3, 2024 09:24
.env-devel Outdated Show resolved Hide resolved
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

sonarcloud bot commented Dec 5, 2024

@GitHK GitHK merged commit 3642829 into ITISFoundation:master Dec 5, 2024
87 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-dynamic-scheduler-scheduling-options branch December 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirement: add dual scheduling (via director-v2 and via dynamic-scheduler)
5 participants