-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Infra: Build for arm64 #6984
base: master
Are you sure you want to change the base?
✨Infra: Build for arm64 #6984
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6984 +/- ##
==========================================
- Coverage 85.52% 81.49% -4.03%
==========================================
Files 1630 120 -1510
Lines 64379 5070 -59309
Branches 2035 0 -2035
==========================================
- Hits 55061 4132 -50929
+ Misses 8984 938 -8046
+ Partials 334 0 -334
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder whether we should also have some of those for development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reassign when ready
2ca1748
to
5e195e4
Compare
02015ca
to
86fb6ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm keep us in the loop on the progress, thx
64389f1
to
cb6a301
Compare
cb6a301
to
1f7b717
Compare
Quality Gate passedIssues Measures |
What do these changes do?
In order to run oSparc on ARM-based processors, this PR allows to build docker images for ARM64 processors
This is useful for cost reduction purposes.
re-used
Makefile
machinery used for building towards Raspberry Pi ARM architecture.1st step shall run manually via triggering. next steps will follow in a separate PR.
some details:
TARGETARCH
variable contains the target architecture (automatically filled in by docker at build time) (see Dockerfile multi-architecture docs)Bonuses:
Current workflow
Currently will be run manually for testing purposes
Related issue/s
How to test
Dev-ops checklist