♻️ Extract workbench from projects to projects_nodes table 🗃️
#7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
added
a:database
giancarloromeo
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7010 +/- ##
==========================================
+ Coverage 87.66% 87.68% +0.02%
==========================================
Files 1632 1626 -6
Lines 63663 63524 -139
Branches 2050 2050
==========================================
- Hits 55810 55701 -109
+ Misses 7516 7486 -30
Partials 337 337
Continue to review full report in Codecov by Sentry.
|
giancarloromeo
changed the title
…ojects-workbench-column
…ojects-workbench-column
…ojects-workbench-column
GitHK
reviewed
Jan 16, 2025
services/web/server/src/simcore_service_webserver/projects/models.py
Outdated
Show resolved
Hide resolved
...ase/src/simcore_postgres_database/migration/versions/50af59b6c37a_move_projects_workbench.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
Jan 16, 2025
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/projects_nodes.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_service.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_service.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_service.py
Show resolved
Hide resolved
…ojects-workbench-column
…:giancarloromeo/osparc-simcore into is5646/extract-projects-workbench-column
…ojects-workbench-column
|
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
workbenchdata from theprojectstable to theprojects_nodesone (some parts might be refined later in next steps).New columns are added to target table (i.e.
projects_nodes) and existing data are copied as part of an Alembic migration.Related issue/s
How to test
Dev-ops checklist