Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Move service extras to catalog #7025

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 10, 2025

⚠️ devops

  • added existing env vars to catalog: DIRECTOR_DEFAULT_MAX_MEMORY and DIRECTOR_DEFAULT_MAX_NANO_CPUS
  • no action needed since env vars are already defined

What do these changes do?

Since we have established that all the data from the services must be owned an provided by the catalog.

The extras are moved to the catalog from the director.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 10, 2025
@GitHK GitHK added t:maintenance Some planned maintenance work a:catalog catalog service a:director-v2 issue related with the director-v2 service labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (abbddb3) to head (527de76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7025      +/-   ##
==========================================
+ Coverage   85.57%   86.98%   +1.41%     
==========================================
  Files        1634     1590      -44     
  Lines       64261    61909    -2352     
  Branches     2050     2050              
==========================================
- Hits        54989    53854    -1135     
+ Misses       8935     7719    -1216     
+ Partials      337      336       -1     
Flag Coverage Δ
integrationtests 64.28% <83.33%> (+0.61%) ⬆️
unittests 85.15% <86.04%> (+1.35%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.43% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.13% <ø> (ø)
pkg_settings_library 90.49% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (+0.11%) ⬆️
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 90.32% <85.89%> (-0.34%) ⬇️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 77.01% <100.00%> (+0.50%) ⬆️
director_v2 91.29% <83.33%> (+0.01%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.17% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.90% <ø> (+5.50%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbddb3...527de76. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend creating a model for the extras

@GitHK GitHK enabled auto-merge (squash) January 21, 2025 09:40
Copy link

@GitHK GitHK merged commit c435616 into ITISFoundation:master Jan 22, 2025
92 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-move-service-extras-to-catalog2 branch January 22, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants