-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Move service extras to catalog #7025
♻️ Move service extras to catalog #7025
Conversation
…rvice-labels-to-catalog-client
…rvice-labels-to-catalog-client
…rvice-labels-to-catalog-client
…rvice-labels-to-catalog-client
…rvice-extras-to-catalog2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7025 +/- ##
==========================================
+ Coverage 85.57% 86.98% +1.41%
==========================================
Files 1634 1590 -44
Lines 64261 61909 -2352
Branches 2050 2050
==========================================
- Hits 54989 53854 -1135
+ Misses 8935 7719 -1216
+ Partials 337 336 -1
Continue to review full report in Codecov by Sentry.
|
services/catalog/src/simcore_service_catalog/api/rest/_services_extras.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend creating a model for the extras
services/catalog/src/simcore_service_catalog/api/rest/_services_extras.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/services/director.py
Outdated
Show resolved
Hide resolved
…rvice-extras-to-catalog2
…rvice-extras-to-catalog2
Quality Gate passedIssues Measures |
DIRECTOR_DEFAULT_MAX_MEMORY
andDIRECTOR_DEFAULT_MAX_NANO_CPUS
What do these changes do?
Since we have established that all the data from the services must be owned an provided by the catalog.
The
extras
are moved to thecatalog
from thedirector
.Related issue/s
How to test
Dev-ops checklist