Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Refactoring of project locking using decorator #7044

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 14, 2025

What do these changes do?

following #7020, this is using the provided decorator to lock projects

  • additional specialized decorator with_project_locked that replaces context manager lock_with_notification' and lock_project` that were flawed as described in the PR above
  • replaced repo-wide the usage of these context managers and removed from code

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:webserver issue related to the webserver service efs-guardian labels Jan 14, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 14, 2025
@sanderegg sanderegg self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.48%. Comparing base (07e603b) to head (7f0986d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
- Coverage   87.51%   87.48%   -0.04%     
==========================================
  Files        1633     1275     -358     
  Lines       63683    53841    -9842     
  Branches     2050     1013    -1037     
==========================================
- Hits        55732    47101    -8631     
+ Misses       7615     6545    -1070     
+ Partials      336      195     -141     
Flag Coverage Δ
integrationtests 63.68% <54.16%> (-0.04%) ⬇️
unittests 85.59% <84.84%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 74.13% <97.56%> (+0.67%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <100.00%> (-0.01%) ⬇️
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.42% <ø> (ø)
director_v2 91.27% <ø> (ø)
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.39% <100.00%> (+0.06%) ⬆️
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.17% <ø> (+0.16%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 85.92% <79.16%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e603b...7f0986d. Read the comment docs.

@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing3 branch 3 times, most recently from 844a93a to c81404e Compare January 17, 2025 12:34
@sanderegg sanderegg marked this pull request as ready for review January 17, 2025 12:34
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. It totally payed back thinking carefully the exclusive decorators!

@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing3 branch 2 times, most recently from 888d8c3 to 8f39f25 Compare January 20, 2025 14:23
@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing3 branch from 8f39f25 to 7f0986d Compare January 21, 2025 10:02
@sanderegg sanderegg merged commit 8909588 into ITISFoundation:master Jan 21, 2025
87 of 93 checks passed
@sanderegg sanderegg deleted the bugfixes/redis-lock-failing3 branch January 21, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service efs-guardian
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants