Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ [Frontend] ViP Market: adapt to latest model #7164

Merged
merged 21 commits into from
Feb 6, 2025
Merged

♻️ [Frontend] ViP Market: adapt to latest model #7164

merged 21 commits into from
Feb 6, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 4, 2025 •
edited
Loading

What do these changes do?

  • Adapt to latest model
  • Display number of seats available on list item and don't make it strong
  • Add link to DOI

AdaptToNewModel

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 4, 2025
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:maintenance Some planned maintenance work labels Feb 4, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 4, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 4, 2025 15:37
@odeimaiz odeimaiz enabled auto-merge (squash) February 4, 2025 15:42
@pcrespov
Copy link
Member

pcrespov commented Feb 4, 2025 •
edited
Loading

Please double check in openapi specs in https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/ITISFoundation/osparc-simcore/5d45c0b1ca93283af8589b28e5cc1b66d50f269d/services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml#tag/licenses/operation/list_licensed_items

@odeimaiz
Copy link
Member Author

odeimaiz commented Feb 4, 2025

Please double check in openapi specs in https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/ITISFoundation/osparc-simcore/5d45c0b1ca93283af8589b28e5cc1b66d50f269d/services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml#tag/licenses/operation/list_licensed_items

what exactly?

GitHK
GitHK approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I guess you already have lots of feedback form others.
I like the display 20 seats available till DATE. If possible I think that something like x/20 seats available till DATE would be better, where x is the amount of currently unused seats.

pcrespov
pcrespov approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@odeimaiz odeimaiz disabled auto-merge February 6, 2025 09:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov enabled auto-merge (squash) February 6, 2025 11:10
@pcrespov pcrespov disabled auto-merge February 6, 2025 11:10
@pcrespov pcrespov merged commit a8a8046 into ITISFoundation:master Feb 6, 2025
56 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 7, 2025
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @pcrespov @GitHK @matusdrobuliak66