move env variable to deploy step

ITPNYU · Mar 16, 2024 · 8469abb · 8469abb
1 parent 4cb0da8
commit 8469abb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/deploy_development.yml b/.github/workflows/deploy_development.yml
@@ -5,9 +5,6 @@ on:
     branches:
       - main
 
-env:
-  REACT_APP_ENVIRONMENT: development
-
 jobs:
   deploy:
     runs-on: ubuntu-latest
@@ -33,6 +30,8 @@ jobs:
       - name: Install clasp
         run: npm install -g @google/clasp
       - name: Push to Google Apps Script
+        env:
+          REACT_APP_ENVIRONMENT: development
         run: |
           cd media_commons_booking_app
           echo "Yes" | npm run deploy

diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml
@@ -4,8 +4,6 @@ on:
   push:
     branches:
       - prod
-env:
-  REACT_APP_ENVIRONMENT: production
 jobs:
   deploy:
     runs-on: ubuntu-latest
@@ -31,6 +29,8 @@ jobs:
       - name: Install clasp
         run: npm install -g @google/clasp
       - name: Push to Google Apps Script
+        env:
+          REACT_APP_ENVIRONMENT: production
         run: |
           cd media_commons_booking_app
           npm run deploy