Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Improve type stability of svdMPO and qn_svdMPO #1183

Merged
merged 12 commits into from
Sep 5, 2023
Merged

[ITensors] Improve type stability of svdMPO and qn_svdMPO #1183

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
324c91d
use function barrier to improve type stability
terasakisatoshi Aug 24, 2023
bf4e854
annotate eltype
terasakisatoshi Aug 24, 2023
c52861c
remove trailing spaces
terasakisatoshi Aug 24, 2023
be0594b
Update src/physics/autompo/opsum_to_mpo_qn.jl
terasakisatoshi Aug 29, 2023
5c61197
Update src/physics/autompo/opsum_to_mpo.jl
terasakisatoshi Aug 29, 2023
8f50641
use `ValType::Type{<:Number}`
terasakisatoshi Aug 30, 2023
24c313b
fix syntax error
terasakisatoshi Aug 30, 2023
5bfb632
run `using JuliaFormatter; format(".")`
terasakisatoshi Aug 30, 2023
ee77780
Update src/physics/autompo/opsum_to_mpo.jl
terasakisatoshi Aug 31, 2023
ff462b9
Update src/physics/autompo/opsum_to_mpo_qn.jl
terasakisatoshi Aug 31, 2023
dd968ad
Update src/physics/autompo/opsum_to_mpo.jl
terasakisatoshi Aug 31, 2023
8e8e85b
Update src/physics/autompo/opsum_to_mpo_qn.jl
terasakisatoshi Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/physics/autompo/opsum_to_mpo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
function svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}
function svdMPO(ValType::Type{<:Number}, os::OpSum{C}, sites; kwargs...)::MPO where {C}
terasakisatoshi marked this conversation as resolved.
Show resolved Hide resolved
mindim::Int = get(kwargs, :mindim, 1)
maxdim::Int = get(kwargs, :maxdim, 10000)
cutoff::Float64 = get(kwargs, :cutoff, 1E-15)

N = length(sites)

ValType = determineValType(terms(os))

Vs = [Matrix{ValType}(undef, 1, 1) for n in 1:N]
Vs = Matrix{ValType}[Matrix{ValType}(undef, 1, 1) for n in 1:N]
mtfishman marked this conversation as resolved.
Show resolved Hide resolved
terasakisatoshi marked this conversation as resolved.
Show resolved Hide resolved
tempMPO = [MatElem{Scaled{C,Prod{Op}}}[] for n in 1:N]

function crosses_bond(t::Scaled{C,Prod{Op}}, n::Int) where {C}
Expand Down Expand Up @@ -117,7 +115,7 @@ function svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}
end

#
# Special handling of starting and
# Special handling of starting and
# ending identity operators:
#
idM = zeros(ValType, dim(ll), dim(rl))
Expand All @@ -138,3 +136,9 @@ function svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}

return H
end #svdMPO

function svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}
# Function barrier to improve type stability
ValType = determineValType(terms(os))
return svdMPO(ValType, os, sites; kwargs...)
end
12 changes: 8 additions & 4 deletions src/physics/autompo/opsum_to_mpo_qn.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
function qn_svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}
function qn_svdMPO(ValType::Type{<:Number}, os::OpSum{C}, sites; kwargs...)::MPO where {C}
terasakisatoshi marked this conversation as resolved.
Show resolved Hide resolved
mindim::Int = get(kwargs, :mindim, 1)
maxdim::Int = get(kwargs, :maxdim, typemax(Int))
cutoff::Float64 = get(kwargs, :cutoff, 1E-15)

N = length(sites)

ValType = determineValType(terms(os))

Vs = [Dict{QN,Matrix{ValType}}() for n in 1:(N + 1)]
Vs = Dict{QN,Matrix{ValType}}[Dict{QN,Matrix{ValType}}() for n in 1:(N + 1)]
mtfishman marked this conversation as resolved.
Show resolved Hide resolved
terasakisatoshi marked this conversation as resolved.
Show resolved Hide resolved
sparse_MPO = [QNMatElem{Scaled{C,Prod{Op}}}[] for n in 1:N]

function crosses_bond(t::Scaled{C,Prod{Op}}, n::Int)
Expand Down Expand Up @@ -251,3 +249,9 @@ function qn_svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}

return H
end #qn_svdMPO

function qn_svdMPO(os::OpSum{C}, sites; kwargs...)::MPO where {C}
# Function barrier to improve type stability
ValType = determineValType(terms(os))
return qn_svdMPO(ValType, os, sites; kwargs...)
end