[ITensors] ITensor wrapping NamedDimsArray
#1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
===========================================
- Coverage 85.44% 53.94% -31.51%
===========================================
Files 89 98 +9
Lines 8402 8489 +87
===========================================
- Hits 7179 4579 -2600
- Misses 1223 3910 +2687 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
47 tasks
|
[test ITensors mps] |
|
Run ITensors mps tests from comment trigger: succeeded ✅ |
1 similar comment
|
Run ITensors mps tests from comment trigger: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality for using the
NamedDimsArraytype introduced in #1267 as a backend for anITensor, entirely circumventing theTensorandTensorStoragetypes.This is along the lines of #1206, #1222, and #1226, though that was still using the
Tensortype.Currently, a full DMRG run works if the MPO and MPS are constructed with ITensors that directly wrap a
NamedDimsArray, though some of the tensor and linear algebra code to make that work is a bit hacky right now and needs to be rewritten in a nicer way. ITensors (as well as MPS/MPO) wrappingTensorandTensorStorageobjects can be converted to ones wrapping aNamedDimsArrayusing theto_nameddimsarrayfunction.The larger goal is to entirely get rid of the
TensorStorageandTensortypes, and in the process simplify the code inNDTensorsandITensors.@kmp5VT @emstoudenmire
Remaining items:
NamedDimsArrayaddition and map code fromITensorsNamedDimsArraysExt/src/tensoralgebra.jltoNamedDimsArrays/src/tensoralgebra.jl.NDTensors.NamedDimsArrays.BaseExtensionstoNDTensors.BaseExtensions.SpectrumfromNDTensors(has been moved toNDTensors.RankFactorization).AlgorithmSelectionsubmodule.BroadcastMapConversionsubmodule for converting broadcast expressions (stored in theBroadcastedobject) to expressions that can call out tomap[!]. Currently that functionality is inNDTensors.NamedDimsArray.Testing:
NamedDimsArraysAdaptExtunit tests are run by the test suite.NamedDimsArrays/src/tensoralgebra.jl.NDTensors.NamedDimsArrays.BaseExtensions(to becomeNDTensors.BaseExtensions).Other TODO items have been moved to #1250, and will be addressed in future work.