Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for working with local registry #6

Closed
wants to merge 8 commits into from

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Nov 29, 2024

Description

This PR ensures that this package becomes compatible with the ITensor/ITensorRegistry local registry, fixing the unregistered dependency problems.

It also makes it compatible with the latest skeleton.

Finally, I fixed some ambiguity errors that Aqua.jl complained about.

Still TODO:

  • Remove type piracy by moving function to TypeParameterAccessors.jl
  • Codecov token

@mtfishman
Copy link
Member

Very cool, thanks for setting that up!

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mtfishman mtfishman mentioned this pull request Dec 2, 2024
2 tasks
@lkdvos lkdvos closed this Dec 5, 2024
@lkdvos lkdvos reopened this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@lkdvos
Copy link
Contributor Author

lkdvos commented Dec 10, 2024

Closed in favor of #8

@lkdvos lkdvos closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants