Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): move the tokenA invalidation after getCredential #139

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jggrimal
Copy link
Contributor

Move the tokenA invalidation after getCredential in CredentialsServerService, because it is the one that is in the context and used during getCredential

Closes #138

…ecause it is the one that is in the context and used during getCredential
@jggrimal jggrimal requested a review from lilgallon October 31, 2024 11:52
@jggrimal jggrimal added bug Something isn't working module: credentials labels Oct 31, 2024
Copy link

Copy link
Member

@lilgallon lilgallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - no breaking change in the lib

@lilgallon lilgallon merged commit 29e9bd2 into main Oct 31, 2024
2 checks passed
@lilgallon lilgallon deleted the fix/#138-invalidate-token-a-after-get-credentials branch October 31, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to know partner in getCredentials() when receiving handshake
2 participants