Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.15: Migrate from kapt/mpApt to ksp #30

Closed
wants to merge 1 commit into from

Conversation

lilgallon
Copy link
Member

@lilgallon lilgallon commented Dec 1, 2023

KSP (https://github.com/google/ksp) is two times faster than kapt and is compatible with K2. We also used mpApt which is no longer maintained since devember 2022 (https://github.com/Foso/MpApt). We also had a custom gradle plugin that we had to publish everytime for us to build the lib. It's no longer required.

I bumped kotlin to 1.9.20, and turned on configuration cache & build cache, and it works without any warning. I also removed generated classes and functions that were on Git. They are now properly generated in the build/generated folder

I did not update / optimize our Partial object mapping logic. I just migrated to KSP. Some work could be done to improve it but it's not the priority now

@lilgallon lilgallon requested a review from xhanin December 1, 2023 16:25
@lilgallon lilgallon force-pushed the 0.0.15-migrate-to-ksp branch from f22d9f8 to 3502746 Compare December 1, 2023 16:30
…urned on build cache & configuration cache. Bump kotlin 1.9.20

The project is now ready for K2. And we do not need the custom annotation processing plugin anymore. Partial files are no longer versioned as they should be in first place
@lilgallon lilgallon force-pushed the 0.0.15-migrate-to-ksp branch from 3502746 to 695ddd3 Compare December 1, 2023 16:31
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lilgallon lilgallon closed this Dec 1, 2023
@lilgallon lilgallon deleted the 0.0.15-migrate-to-ksp branch December 1, 2023 16:35
@lilgallon lilgallon removed the request for review from xhanin December 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant