fix: add a more meaningful exception in parseAnyFromString and add classResponse to the Actions enum #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xhanin
reviewed
Mar 13, 2024
| @@ -34,6 +34,13 @@ class Ocpp15JsonParser( | |||
| throw errorHandler(e) | |||
| } | |||
|
|
|||
| override fun getResponsePayloadClass(action: String, errorHandler: (e: Exception) -> Throwable): Class<out Any> = | |||
There was a problem hiding this comment.
c'est overkill de fournir une lamba pour construire l'exception ici, non ? pourquoi on ne laisse pas la responsabilité à l'appelant ? C'est sans doute lié à ma demande dans l'autre projet mais maintenant qu'on fait ça ici je n'y vois pas d'interet
There was a problem hiding this comment.
autant pour moi, c'est pour être consistant avec l'autre methode, donc ok pour moi
xhanin
approved these changes
Mar 13, 2024
jggrimal
deleted the
feat/add-response-classes-to-actions-and-new-exception-to-parser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a more meaningful exception in parseAnyFromString, when we try to parse a response without specifying a useClazz to do so (cannot be inferred from response content)
Add classResponse to the Actions enum in the same way as classRequest