feat: EVSIM-437 add message id in request metadata #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhanin
reviewed
Apr 25, 2024
| @@ -105,7 +105,7 @@ class OcppSoapServerTransport private constructor( | |||
| msg.action?.lowercase() == action.lowercase() | |||
| ) { | |||
| val message = ocppSoapParser.parseRequestFromSoap(msg.payload, clazz) | |||
| val response = onAction(RequestMetadata(message.messageId), message.payload) | |||
| val response = onAction(RequestMetadata(message.messageId, message.messageId), message.payload) | |||
There was a problem hiding this comment.
c'est étrange ici on passe 2 fois le messageId ? Ca semble être une erreur dans l'implem actuelle qui passe le messageId en tant que chargingStationId ?
There was a problem hiding this comment.
En effet c'est une erreur qu'on a dans l'implem actuelle, c'est corrigé
|
DeborahPereira4sh
deleted the
feat-EVSIM-437-add-message-id-in-request-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://4sh-toolkit.atlassian.net/browse/EVSIM-437
Ajout du message id dans les request metadata afin qu'il soit directement accessible lors de l'implémentation des callbacks, qui ont la signature suivante par exemple :